git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Wrap completions in `type git' conditional statement.

From
Shawn O. Pearce <spearce@spearce.org>
Date
Dec 29, 2009, 15:02 UTC
Message-ID
<20091229150217.GB6152@spearce.org>
In-Reply-To
<20091229200530.6117@nanako3.lavabit.com>
Nanako Shiraishi <nanako3@lavabit.com> wrote:
> Junio, could you tell us what happened to this thread?
> 
> The patch avoids failing completion script when git is not there.
> No discussion.

Actually, that's probably my fault. I never sent an ack or nak, or anything else really, on this thread.

Originally this was because the completion was trying to run git as it loaded. In 1.6.6 this is no longer true, the completion list is generated lazily on demand during the first completion attempt.

With the lazy loading, I didn't see a reason to add this ugly block around the entire script.

-- 
Shawn.
Previous: Nanako ShiraishiNext: Junio C Hamano
Message 3 of 5 in “Wrap completions in `type git' conditional statement.”
  1. Wrap completions in `type git' conditional statement.Sung Pae, Nov 12, 2009
  2. Nanako ShiraishiDec 29, 2009
  3. Shawn O. PearceDec 29, 2009
  4. Junio C HamanoDec 29, 2009
  5. Nanako ShiraishiDec 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.