Re: [PATCH] git svn: make empty directory creation gc-aware

From: Eric Wong <normalperson@yhbt.net>
Date: Dec 20, 2009, 07:21 UTC
Message-ID: <20091220072015.GB8141@dcvr.yhbt.net>
In-Reply-To: <7vzl5e3yx3.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> >   More pushes hopefully coming as Sam and Andrew work out the mergeinfo
> >   performance problems and I look into crossing svn-remote boundaries
> >   for parent lookups.
> 
> Thanks.
> 
> This particular patch should be in 1.6.6 final, because mkdirs first
> appeared in 1.6.6-rc0 at 6111b93 (git svn: attempt to create empty dirs on
> clone+rebase, 2009-11-15), and 1.6.5.X series does not have the command,
> so this seems like a new feature that never existed in any tagged release,
> and if we shipped 1.6.6 without this patch, we will be shipping it with a
> know breakage, while if we shipped it with this, even if this patch
> somehow had an unintended side effect, at worst we'd be exchanging a bug
> with some other bug, so it wouldn't be worse.

I agree completely.

Show 5 quoted lines

> Is mkdirs the only "noteworthy" feature that should be mentioned in the
> Release Notes in your area?  It would be really nice if you can give a
> patch to Documentation/RelNotes-1.6.6.txt in a few days to turn a single
> liner I have there to something more helpful.  The current shortlog since
> 1.6.5 indicates there weren't that much activity during this release.

Sam's merge handling work is definitely noteworthy, but it's already in the release notes, hopefully the performance regression there is worked out. I'll definitely send you a patch to the release notes after I get a chance to figure out the other issue with multiple svn-remotes tonight/tomorrow.

-- 
Eric Wong