Re: Re: Re: [RFC PATCH v2 0/2] git-gui: (un)stage a range of changes at once

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Dec 11, 2009, 18:57 UTC
Message-ID: <20091211185706.GA52891@book.hvoigt.net>
In-Reply-To: <20091208003836.GB22330@unpythonic.net>

On Mon, Dec 07, 2009 at 06:38:36PM -0600, Jeff Epler wrote:

Show 16 quoted lines

> On Mon, Dec 07, 2009 at 01:54:35PM +0100, Heiko Voigt wrote:
> > Jeff could you clarify or provide an example?
> 
> If I recall correctly, the problem with the v2 patch was when the change
> was like
>     @@ -13,8 +13,8 @@ set appvers {@@GITGUI_VERSION@@}
>      set copyright [encoding convertfrom utf-8 {
>      Copyright © 2006, 2007 Shawn Pearce, et. al.
> 
>     -This program is free software; you can redistribute it and/or modify
>     -it under the terms of the GNU General Public License as published by
>     +blah blah
>     +blah blah
>      the Free Software Foundation; either version 2 of the License, or
>      (at your option) any later version.
> and the 'blah blah' lines were both staged in the same operation.

Thanks Jeff that was the missing piece. I was able to reproduce the behavior and I can confirm it is gone with the new series. I was not yet able to read through all of the code.

cheers Heiko