git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH resend 0/3] transport: catch non-fast-forwards

From
Tay Ray Chuan <rctay89@gmail.com>
Date
Dec 4, 2009, 06:54 UTC
Message-ID
<20091204145437.1a9910db.rctay89@gmail.com>

This patch series applies on top of 'next', and deals with alerting the user to non-fast-forward pushes when using helpers (smart).

Previously, git silently exited. This situation involves the curl helper and the smart protocol. The fast-forward push is only detected when curl executes the rpc client (git-send-pack). Now, we detect it before telling the helper to push.

The first patch refactors ref status logic out of builtin-send-pack.c.

The second patch lets git know of non-fast-forwards before actually telling the helper to push anything.

The third patch changes the return code when ref status indicate an error (determined by push_had_errors()), so that the caller of transport_push() is alerted.

PS. There are at least 2 bug fixes related to this series. If you usually do so from repo.or.cz, please fetch from git.kernel.org; the former is 2 days old.

 builtin-send-pack.c |   39 +++------------------------------------
 remote.c            |   42 ++++++++++++++++++++++++++++++++++++++++++
 remote.h            |    1 +
 transport-helper.c  |   10 +++-------
 transport.c         |   11 +++++++----
 5 files changed, 56 insertions(+), 47 deletions(-)

-- Cheers, Ray Chuan

Next: Tay Ray Chuan
Message 1 of 12 in “transport: catch non-fast-forwards”
  1. 0/3 transport: catch non-fast-forwardsTay Ray Chuan, Dec 4, 2009
  2. 1/3 refactor ref status logic for pushingTay Ray Chuan, Dec 4, 2009
  3. 2/3 transport-helper.c::push_refs(): know more about refs before pushingTay Ray Chuan, Dec 4, 2009
  4. 3/3 transport.c::transport_push(): make ref status affect return valueTay Ray Chuan, Dec 4, 2009
  5. Jeff KingDec 4, 2009
  6. 0/6 transport: catch non-fast forwardsTay Ray Chuan, Jan 8, 2010
  7. 1/6 t5541-http-push.sh: add tests for non-fast-forward pushesTay Ray Chuan, Jan 8, 2010
  8. 2/6 t5541-http-push.sh: add test for unmatched, non-fast-forwarded refsTay Ray Chuan, Jan 8, 2010
  9. 3/6 refactor ref status logic for pushingTay Ray Chuan, Jan 8, 2010
  10. 4/6 transport.c::transport_push(): make ref status affect return valueTay Ray Chuan, Jan 8, 2010
  11. 5/6 transport-helper.c::push_refs(): ignore helper-reported status if ref is not to be pushedTay Ray Chuan, Jan 8, 2010
  12. 6/6 transport-helper.c::push_refs(): emit "no refs" error messageTay Ray Chuan, Jan 8, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.