Re: What's cooking in git.git (Nov 2009, #06; Wed, 25)

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Nov 27, 2009, 14:45 UTC
Message-ID: <20091127144553.GA24366@progeny.tock>
In-Reply-To: <20091127065904.GE20844@coredump.intra.peff.net>

Jeff King wrote:

> On Wed, Nov 25, 2009 at 05:03:33PM -0800, Junio C Hamano wrote:

Show 8 quoted lines

>> * jc/grep-full-tree (2009-11-24) 1 commit.
>>  - grep: --full-tree
>> 
>> We probably would want test, doc and a configuration variable to make it
>> default (or non-default) before we can merge it to 'master'.
>
> I can try to pick this up. But did we reach a decision on having a
> configuration variable?

I am not sure, but I will say I would prefer not to have one. Surely we can come up with a UI that does not require searching through git-config(1) to be made convenient.

Couldn’t we just add the option (with test and documentation) first, to get some experience with how we end up using the two forms?

If --full-tree does become the default, I think it should be in 1.7.0, when it is expected for some habits to break (with a configuration variable for the transition, I guess). This might be okay, since constructions like 'git grep foo -- "./*.h"' should still work.