git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCHv8 08/10] fast-import: Proper notes tree manipulation using the notes API

From
Shawn O. Pearce <spearce@spearce.org>
Date
Nov 26, 2009, 19:33 UTC
Message-ID
<20091126193323.GU11919@spearce.org>
In-Reply-To
<200911261210.48138.johan@herland.net>
Johan Herland <johan@herland.net> wrote:
Show 5 quoted lines
> BTW, while we're on the topic, this whole code is only present because I 
> assume it's not possible to edit the fast-import tree structure _while_ 
> traversing it. Is this assumption correct, or are there ways to get 
> around maintaining a separate edit list that is applied to the tree 
> structure afterwards?

IIRC you can actually edit the tree while you are walking through it. You just have to watch out for the fact that a struct tree_content can be reallocated (and thus moved in memory) if the entry_capacity was too small for the new entry_count when inserting a new entry.

tree_content_set() handles this in its API by taking a struct tree_entry* rather than a struct tree_content*. This way if the tree has to expand during the set and gets reallocated we can return the new tree pointer to the caller through the struct tree_entry tree field.

-- 
Shawn.
Previous: Johan HerlandNext: Johan Herland
Message 12 of 26 in “[RFC/PATCHv8 00/10] git notes”
  1. Johan HerlandNov 20, 2009
  2. 01/10 Notes API: get_commit_notes() -> format_note() + remove the commit restrictionJohan Herland, Nov 20, 2009
  3. 02/10 Notes API: init_notes(): Initialize the notes tree from the given notes refJohan Herland, Nov 20, 2009
  4. 03/10 Notes API: add_note(): Add note objects to the internal notes tree structureJohan Herland, Nov 20, 2009
  5. 04/10 Notes API: get_note(): Return the note annotating the given objectJohan Herland, Nov 20, 2009
  6. 05/10 Notes API: for_each_note(): Traverse the entire notes tree with a callbackJohan Herland, Nov 20, 2009
  7. 06/10 Notes API: Allow multiple concurrent notes trees with new struct notes_treeJohan Herland, Nov 20, 2009
  8. 07/10 Refactor notes concatenation into a flexible interface for combining notesJohan Herland, Nov 20, 2009
  9. 08/10 fast-import: Proper notes tree manipulation using the notes APIJohan Herland, Nov 20, 2009
  10. Shawn O. PearceNov 26, 2009
  11. Johan HerlandNov 26, 2009
  12. Shawn O. PearceNov 26, 2009
  13. 09/10 Rename t9301 to t9350, to make room for more fast-import testsJohan Herland, Nov 20, 2009
  14. 10/10 Add more testcases to test fast-import of notesJohan Herland, Nov 20, 2009
  15. Junio C HamanoNov 20, 2009
  16. Johan HerlandNov 20, 2009
  17. Nanako ShiraishiNov 20, 2009
  18. Johannes SchindelinNov 20, 2009
  19. Junio C HamanoNov 20, 2009
  20. Junio C HamanoNov 20, 2009
  21. Alex RiesenJan 19, 2010
  22. Junio C HamanoJan 19, 2010
  23. Junio C HamanoJan 20, 2010
  24. Johannes SixtJan 20, 2010
  25. Junio C HamanoJan 20, 2010
  26. Alex RiesenJan 20, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.