Re: Client-side mirroring patches (v0)

From: Shawn O. Pearce <spearce@spearce.org>
Date: Nov 26, 2009, 00:58 UTC
Message-ID: <20091126005837.GN11919@spearce.org>
In-Reply-To: <1259143617-26580-1-git-send-email-sam@vilain.net>

Sam Vilain <sam@vilain.net> wrote:

> Hey folks, this is the first stage of git mirroring

...

> Also there is the matter of falling over to the next mirror should one
> not be reachable, but then we're getting into C weaknesses really.
> Should I plan to do exception recovery using 'longjmp' ?

Please don't use longjmp.

You'll have to change the code to not die() upon connection failure, but instead return an error code to the higher level which can locate another mirror and retry.

> Also the
> process should be interruptible and provide a user menu.  Again this
> seems like it would be very tedious and clumsy in C.  How do people
> manage?

With great pain.  :-)

To do a user menu you can do a simple interface like `git add -i` does, which just dumps the choices to stdout and a prompt for the user to enter their selection. If you want something more complex you need to link to curses or ncurses, which IIRC opens some issues with portablity, but lets you do a bit nicer interface on the tty.

-- 
Shawn.