git/list[1] front-page[2] threads[3] people[4] search[5] about
 

git-svn: Fails to drop leading path from empty dir name

From
Björn Steinbrink <b.steinbrink@gmx.de>
Date
Nov 22, 2009, 13:46 UTC
Message-ID
<20091122134638.GA12233@atjola.homenet>
Hi Eric,

the stuff to create empty directories fails to strip leading path components, e.g. when using "git svn clone -s svn://whatever/project/trunk".

Instead of creating the empty directory "foo" in the repo root, it creates "project/trunk/foo".

Ad hoc patch for the test case below.
Björn
diff --git a/t/t9146-git-svn-empty-dirs.sh b/t/t9146-git-svn-empty-dirs.sh
index 5948544..9e22089 100755
--- a/t/t9146-git-svn-empty-dirs.sh
+++ b/t/t9146-git-svn-empty-dirs.sh
@@ -82,4 +82,27 @@ test_expect_success 'git svn mkdirs -r works' '
 	)
 '
 
+test_expect_success 'initialize trunk' '
+	for i in trunk trunk/a trunk/"weird file name"
+	do
+		svn_cmd mkdir -m "mkdir $i" "$svnrepo"/"$i"
+	done
+'
+
+test_expect_success 'clone trunk' 'git svn clone -s "$svnrepo" trunk'
+
+test_expect_success 'empty directories in trunk exist' '
+	(
+		cd cloned &&
+		for i in trunk/a trunk/"weird file name"
+		do
+			if ! test -d "$i"
+			then
+				echo >&2 "$i does not exist"
+				exit 1
+			fi
+		done
+	)
+'
+
 test_done
Next: Eric Wong
Message 1 of 4 in “git-svn: Fails to drop leading path from empty dir name”
  1. Björn SteinbrinkNov 22, 2009
  2. Eric WongNov 22, 2009
  3. Björn SteinbrinkNov 22, 2009
  4. git svn: strip leading path when making empty dirsEric Wong, Nov 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.