Re: [PATCH v3] Speed up bash completion loading

From: Shawn O. Pearce <spearce@spearce.org>
Date: Nov 18, 2009, 00:59 UTC
Message-ID: <20091118005923.GB11919@spearce.org>
In-Reply-To: <20091118004910.GA5729@progeny.tock>

Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 11 quoted lines

> Since git is not used in each and every interactive xterm, it
> seems best to load completion support with cold caches and then
> load each needed thing lazily.  This has most of the speed
> advantage of pre-generating everything at build time, without the
> complication of figuring out at build time what commands will be
> available at run time.
> 
> On this slow laptop, this decreases the time to load
> git-completion.bash from about 500 ms to about 175 ms.
> 
> Suggested-by: Kirill Smelkov <kirr@mns.spb.ru>

Yup, still...

> Acked-by: Shawn O. Pearce <spearce@spearce.org>

:-)

> I do not know whether it is kosher to carry over an ack like this.
> The interdiff is small, for what it???s worth:

Usually you leave it in if all you've done is address minor reviewer comments and they had actually supplied an Acked-by line for the prior version.

Its also usually fine to leave it like this, because there is a good chance that the reviewer will agree with the new version and it saves Junio from needing to insert the line himself later.

But it would be bad form to leave an Acked-by in if there was a major
rewrite.  E.g. this particular fix has gone through some really major
rework to reach this point, keeping an Acked-by from the very first
"speedup loading" patch (which IIRC computed them at build time) into
this one would be quite unfriendly.

-- 
Shawn.