Re: [PATCH] RFC Allow case insensitive search flag with git-grep for fixed-strings
- From
Jeff King <peff@peff.net>
- Date
- Nov 17, 2009, 07:38 UTC
- Message-ID
- <20091117073845.GC4007@coredump.intra.peff.net>
- In-Reply-To
- <7v639am2uq.fsf@alter.siamese.dyndns.org>
On Mon, Nov 16, 2009 at 04:06:37PM -0800, Junio C Hamano wrote:
> By the way, I would suggest updating the test like the attached. > > By looking for rEtUrN, you will catch a bug that breaks "-i"-ness > of the grep, but your test does not catch breakages in "-F"-ness.
Your change looks good to me.
-Peff