Re: [PATCH 1/2] git-svn: add (failing) test for SVN 1.5+ merge with intervening commit
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Nov 16, 2009, 01:30 UTC
- Message-ID
- <20091116013013.GA3829@dcvr.yhbt.net>
- In-Reply-To
- <87k4xrb785.fsf@navakl084.mitacad.com>
Toby Allsopp <Toby.Allsopp@navman.co.nz> wrote:
Show 14 quoted lines
> [Dropped Junio from CC] > > On Sun, Nov 15 2009, Eric Wong wrote: > > > Hi Toby, > > > > Thanks for this series, acked and squashed into a single commit to avoid > > unnecessary bisection failures at git://git.bogomips.org/git-svn > > Great, thanks. I have no objection to being squashed, but I'm not sure > what you mean by bisection failures. Does a test_expect_failure cause > problems for bisection? It appears to be fairly common to introduce a > failing test case and later fix it, e.g. ce06461 then 751c597. I'd just > like to understand any potential problems with what I did.
Oops. I didn't even notice you had test_expect_failure there :x I'll just leave it as is incase somebody has already pulled from me (other, unrelated patches coming in a few)
-- Eric Wong