[RFC, PATCH] git send-email: Make --no-chain-reply-to the default
- From
- Ingo Molnar <mingo@elte.hu>
- Date
- Nov 10, 2009, 04:08 UTC
- Message-ID
- <20091110040847.GC29454@elte.hu>
- In-Reply-To
- <1257789555.4108.348.camel@laptop>
(moved from lkml to the Git list)
* Peter Zijlstra <peterz@infradead.org> wrote:
> > Mailer: > > git-send-email 1.6.5.2 > > Please teach your git-send-email thing to use --no-chain-reply-to.
about half of every patch series that gets sent to me on lkml is unreadable in my email client due to the default threading that git-send-email does. It looks like this:
28685 r T Nov 05 Hitoshi Mitake ( 31) [PATCH v5 0/7] Adding general performance benchmarki 28686 T Nov 05 Hitoshi Mitake ( 31) +->[PATCH v5 1/7] Adding new directory and header fo 28687 T Nov 05 Hitoshi Mitake ( 368) | +->[PATCH v5 2/7] sched-messaging.c: benchmark for 28688 T Nov 05 Hitoshi Mitake ( 148) | | +->[PATCH v5 3/7] sched-pipe.c: benchmark for pi 28689 T Nov 05 Hitoshi Mitake ( 149) | | | +->[PATCH v5 4/7] builtin-bench.c: General fra 28690 T Nov 05 Hitoshi Mitake ( 24) | | | | +->[PATCH v5 5/7] Modifying builtin.h for ne 28691 T Nov 05 Hitoshi Mitake ( 25) | | | | | +->[PATCH v5 6/7] Modyfing perf.c for subc 28692 T Nov 05 Hitoshi Mitake ( 30) | | | | | | +->[PATCH v5 7/7] Modyfing Makefile to b
and with 10 or more patches it's an absolute pain as threading depth increases. Furthermore, the subject lines are not aligned vertically, making it very hard to see the general shortlog-alike structure of the series, at a glance. Plus i dont even _see_ the title over a certain depth, as i run out of screen real estate.
So ... the question would be ... could git-send-email flip its default please, via the patch below? Am i missing something subtle about why this default was chosen?
Ingo
Signed-off-by: Ingo Molnar <mingo@elte.hu>
diff --git a/git-send-email.perl b/git-send-email.perl index a0279de..ff00940 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -188,7 +188,7 @@ my (@suppress_cc); my %config_bool_settings = ( "thread" => [\$thread, 1], - "chainreplyto" => [\$chain_reply_to, 1], + "chainreplyto" => [\$chain_reply_to, 0], "suppressfrom" => [\$suppress_from, undef], "signedoffbycc" => [\$signed_off_by_cc, undef], "signedoffcc" => [\$signed_off_by_cc, undef], # Deprecated