git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH 0/3] use '--bisect-refs' as bisect rev machinery option

From
Christian Couder <chriscool@tuxfamily.org>
Date
Nov 4, 2009, 04:00 UTC
Message-ID
<20091104034312.4545.2176.chriscool@tuxfamily.org>

So I suggest to use '--bisect-refs' instead of '--bisect' as the new bisect revision machinery option, because otherwise I think we get a regression when we call "git rev-list --bisect BAD --not GOOD" and we are already bisecting with bisect refs different than BAD and GOOD. This also simplifies the code a little bit.

I had a look at using '--bisect-refs' in the git bisect helper instead of collecting the good and bad refs in bisect.c::read_bisect_refs(), but I gave up because I think we need the good and bad refs anyway for other purposes like checking that all good refs are ancestor of the bad ref. So I think we would not gain much if anything there.

If this is ok then the next steps I can do is add some documentation and tests for the new '--bisect-refs' option.

Christian Couder (3):
  t6030: show "rev-list --bisect" breakage when bisecting
  revision: change '--bisect' rev machinery argument to 'bisect-refs'
  bisect: simplify calling visualizer using '--bisect-refs'
 builtin-rev-list.c          |    2 --
 builtin-rev-parse.c         |    4 ++--
 git-bisect.sh               |    3 +--
 revision.c                  |    5 ++---
 revision.h                  |    1 -
 t/t6030-bisect-porcelain.sh |   13 +++++++++++++
 6 files changed, 18 insertions(+), 10 deletions(-)
Next: Christian Couder
Message 1 of 11 in “use '--bisect-refs' as bisect rev machinery option”
  1. 0/3 use '--bisect-refs' as bisect rev machinery optionChristian Couder, Nov 4, 2009
  2. 1/3 t6030: show "rev-list --bisect" breakage when bisectingChristian Couder, Nov 4, 2009
  3. 2/3 revision: change '--bisect' rev machinery argument to 'bisect-refs'Christian Couder, Nov 4, 2009
  4. 3/3 bisect: simplify calling visualizer using '--bisect-refs'Christian Couder, Nov 4, 2009
  5. Junio C HamanoNov 4, 2009
  6. Linus TorvaldsNov 4, 2009
  7. Linus TorvaldsNov 4, 2009
  8. Junio C HamanoNov 4, 2009
  9. Christian CouderNov 4, 2009
  10. Junio C HamanoNov 4, 2009
  11. Christian CouderNov 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.