Re: [PATCH] Don't create the $GIT_DIR/branches directory on init
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Oct 31, 2009, 18:24 UTC
- Message-ID
- <20091031182416.GO10505@spearce.org>
- In-Reply-To
- <7vr5sj8m5f.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> Modern git Porcelains write remote definitions solely to .git/config, but
> still reads from .git/{branches,remotes}....
> Andrew Morton explicitly asked for this to be kept a few years > ago and I do not see a reason to deprecate this.
...
> Shawn and other wants to stop JGit from creating this directory on
I probably said something like this. I won't bother denying it, because list archives are more accurate than my own fallible memory.
But I didn't know the Andrew Morton part above. After hearing it from you, I'm reversing my (apparent) direction here. We should continue to create the branches directory within a new repository.
Sorry Robin, but Andrew Morton matters. Its one stupid unused directory in a repository that will chew through thousands of inodes as loose objects. Its a drop in the bucket in terms of resource cost used by Git. And Andrew is someone whose workflow we don't want to break if we can avoid it. He's a long time Git user who is also high up in the kernel food chain. Interrupting him disrupts a fair chunk of kernel work while he grumbles about the Goddamn Idiotic Truckload of s**t that Linus begat.
> This patch alone breaks tests in the t55?? series quite a lot,
Drop the patch.
-- Shawn.