git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH ef/msys-imap] mingw: use BLK_SHA1 again

From
Johannes Sixt <j6t@kdbg.org>
Date
Oct 22, 2009, 18:26 UTC
Message-ID
<200910222026.29885.j6t@kdbg.org>
In-Reply-To
<200910222011.02737.j6t@kdbg.org>

Since NO_OPENSSL is no longer defined on Windows, BLK_SHA1 is not defined anymore implicitly. Define it explicitly.

As a nice side-effect, we no longer link against libcrypto.dll, which has non-trivial startup costs because it depends on 6 otherwise unneeded DLLs.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
On Donnerstag, 22. Oktober 2009, Johannes Sixt wrote:
> ... and I have one more patch to be applied on top of the series.

Here it is. I haven't tested the MSVC aspect of the patch. I would appreciate feedback in this regard.

-- Hannes
 Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 5403fad..f666d2f 100644
--- a/Makefile
+++ b/Makefile
@@ -911,6 +911,7 @@ ifdef MSVC
 	NO_REGEX = YesPlease
 	NO_CURL = YesPlease
 	NO_PTHREADS = YesPlease
+	BLK_SHA1 = YesPlease
 
 	CC = compat/vcbuild/scripts/clink.pl
 	AR = compat/vcbuild/scripts/lib.pl
@@ -960,6 +961,7 @@ ifneq (,$(findstring MINGW,$(uname_S)))
 	UNRELIABLE_FSTAT = UnfortunatelyYes
 	OBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo
 	NO_REGEX = YesPlease
+	BLK_SHA1 = YesPlease
 	COMPAT_CFLAGS += -D__USE_MINGW_ACCESS -DNOGDI -Icompat -Icompat/fnmatch
 	COMPAT_CFLAGS += -DSTRIP_EXTENSION=\".exe\"
 	COMPAT_OBJS += compat/mingw.o compat/fnmatch/fnmatch.o compat/winansi.o
-- 
1.6.5.rc3.70.gfc1aa
Previous: Johannes SixtNext: Johannes Schindelin
Message 13 of 16 in “imap-send: Windows support”
  1. 0/8 imap-send: Windows supportErik Faye-Lund, Oct 21, 2009
  2. 1/8 imap-send: remove useless uid codeErik Faye-Lund, Oct 21, 2009
  3. 2/8 imap-send: use separate read and write fdsErik Faye-Lund, Oct 21, 2009
  4. 3/8 imap-send: use run-command API for tunnelingErik Faye-Lund, Oct 21, 2009
  5. 4/8 imap-send: fix compilation-error on WindowsErik Faye-Lund, Oct 21, 2009
  6. 5/8 imap-send: build imap-send on WindowsErik Faye-Lund, Oct 21, 2009
  7. 6/8 mingw: wrap SSL_set_(w|r)fd to call _get_osfhandleErik Faye-Lund, Oct 21, 2009
  8. 7/8 mingw: enable OpenSSLErik Faye-Lund, Oct 21, 2009
  9. 8/8 MSVC: Enable OpenSSL, and translate -lcryptoErik Faye-Lund, Oct 21, 2009
  10. Johannes SixtOct 22, 2009
  11. Johannes SchindelinOct 22, 2009
  12. Johannes SixtOct 22, 2009
  13. mingw: use BLK_SHA1 againJohannes Sixt, Oct 22, 2009
  14. Johannes SchindelinOct 26, 2009
  15. Johannes SixtOct 27, 2009
  16. Junio C HamanoOct 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.