git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git push: say that --tag can't be used with --all or --mirror in help text

From
Jeff King <peff@peff.net>
Date
Oct 21, 2009, 14:42 UTC
Message-ID
<20091021144203.GA30485@coredump.intra.peff.net>
In-Reply-To
<20091019125701.6117@nanako3.lavabit.com>
On Mon, Oct 19, 2009 at 12:57:01PM +0900, Nanako Shiraishi wrote:
> -		OPT_BOOLEAN( 0 , "tags", &tags, "push tags"),
> +		OPT_BOOLEAN( 0 , "tags", &tags, "push tags (can't be used with --all nor --mirror"),

Hmm. We apparently all managed to miss this typo. It's visually hard to notice because of the ")" closing the macro.

-- >8 --
Subject: [PATCH] push: fix typo in usage
Missing ")".
Signed-off-by: Jeff King <peff@peff.net>
---
 builtin-push.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-push.c b/builtin-push.c
index 7d78711..019c986 100644
--- a/builtin-push.c
+++ b/builtin-push.c
@@ -181,7 +181,7 @@ int cmd_push(int argc, const char **argv, const char *prefix)
 		OPT_BIT( 0 , "all", &flags, "push all refs", TRANSPORT_PUSH_ALL),
 		OPT_BIT( 0 , "mirror", &flags, "mirror all refs",
 			    (TRANSPORT_PUSH_MIRROR|TRANSPORT_PUSH_FORCE)),
-		OPT_BOOLEAN( 0 , "tags", &tags, "push tags (can't be used with --all or --mirror"),
+		OPT_BOOLEAN( 0 , "tags", &tags, "push tags (can't be used with --all or --mirror)"),
 		OPT_BIT( 0 , "purge", &flags,
 			"remove locally deleted refs from remote",
 			TRANSPORT_PUSH_PURGE),
-- 
1.6.5.1.139.g6f544.dirty
Previous: Jeff KingNext: Nanako Shiraishi
Message 13 of 18 in “[ANNOUNCE] GIT 1.6.5”
  1. Junio C HamanoOct 11, 2009
  2. Steven NoonanOct 11, 2009
  3. Steven NoonanOct 11, 2009
  4. Junio C HamanoOct 11, 2009
  5. Steven NoonanOct 11, 2009
  6. Jakub NarebskiOct 14, 2009
  7. Sebastian PippingOct 18, 2009
  8. Document git push -qMiklos Vajna, Oct 18, 2009
  9. git push: remove incomplete options list from help textNanako Shiraishi, Oct 19, 2009
  10. Junio C HamanoOct 19, 2009
  11. git push: say that --tag can't be used with --all or --mirror in help textNanako Shiraishi, Oct 19, 2009
  12. Jeff KingOct 19, 2009
  13. Jeff KingOct 21, 2009
  14. Nanako ShiraishiOct 21, 2009
  15. Jeff KingOct 19, 2009
  16. Junio C HamanoOct 19, 2009
  17. Jeff KingOct 19, 2009
  18. Junio C HamanoOct 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.