Re: [PATCH v3 3/8] imap-send: use run-command API for tunneling
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Oct 14, 2009, 19:58 UTC
- Message-ID
- <200910142158.59073.j6t@kdbg.org>
- In-Reply-To
- <40aa078e0910131327q682c7044x854fec4de60b0c43@mail.gmail.com>
On Dienstag, 13. Oktober 2009, Erik Faye-Lund wrote:
Show 8 quoted lines
> If I were to fix this, I'd prefer not using sh at all on Windows. I've > seen that connect.c doesn't prepend "/bin/sh -c" at all, requiring > tunnels to be self-contained scripts or native binaries, unless I'm > mistaken. I'm not sure if this works at all on Windows, though. I just > think that the assumption that sh is the shell that is going to run > the tunnel is wrong to make, especially on Windows. > > I'm really unsure if it's worth the hassle.
We already depend on the existence of a Bourne shell for our scripted commands. There are already more places in the code that run "sh" than "/bin/sh".
-- Hannes