git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 2/5] Introduce new pretty formats %g and %G for reflog information

From
Jeff King <peff@peff.net>
Date
Oct 14, 2009, 04:59 UTC
Message-ID
<20091014045918.GA31810@coredump.intra.peff.net>
In-Reply-To
<e0321a8af8d702d24ace33510daff22d02f4e116.1255380039.git.trast@student.ethz.ch>
On Mon, Oct 12, 2009 at 11:06:04PM +0200, Thomas Rast wrote:
> Unfortunately, we also need to pass down the reflog_walk_info from
> show_log(), so this commit touches a lot of (unrelated) callers to
> pretty_print_commit() and format_commit_message() to accomodate the
> extra argument.

A while back I wanted to add a feature to pretty-printing, and I ran into the same situation (though my feature never made it to the list). We really end up passing around the same arguments over and over. Maybe it makes sense instead of adding another argument to refactor into a "pretty_print_context" struct that contains all of the arguments and current state.

It would be an even more invasive patch, but I think it would make things more readable, and make future changes much easier to see.

-Peff
Previous: Thomas RastNext: Thomas Rast
Message 4 of 14 in “Pretty formats for reflog data”
  1. 0/5 Pretty formats for reflog dataThomas Rast, Oct 12, 2009
  2. 1/5 reflog-walk: refactor the branch@{num} formattingThomas Rast, Oct 12, 2009
  3. 2/5 Introduce new pretty formats %g and %G for reflog informationThomas Rast, Oct 12, 2009
  4. Jeff KingOct 14, 2009
  5. Thomas RastOct 14, 2009
  6. Junio C HamanoOct 14, 2009
  7. 3/5 stash: Use new %g/%G formats instead of sedThomas Rast, Oct 12, 2009
  8. Jeff KingOct 14, 2009
  9. 4/5 stash list: drop the default limit of 10 stashesThomas Rast, Oct 12, 2009
  10. Jeff KingOct 14, 2009
  11. 5/5 stash: change built-in ref to 'stash' instead of 'refs/stash'Thomas Rast, Oct 12, 2009
  12. Jeff KingOct 14, 2009
  13. Jeff KingOct 12, 2009
  14. Thomas RastOct 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.