Re: [PATCH] Speedup bash completion loading

From: Shawn O. Pearce <spearce@spearce.org>
Date: Oct 9, 2009, 15:39 UTC
Message-ID: <20091009153936.GV9261@spearce.org>
In-Reply-To: <20091009152149.GA26171@tugrik.mns.mnsspb.ru>

Kirill Smelkov <kirr@mns.spb.ru> wrote:

Show 8 quoted lines

> On Fri, Oct 09, 2009 at 07:46:06AM -0700, Shawn O. Pearce wrote:
> > 
> > Squash this into the first patch and add the egrep change made by
> > Stephen Boyd "[PATCH 1/2] completion: fix completion of git <TAB><TAB>".
> 
> While it is technically easy to do so, isn't this a bad idea to squash
> semantic changes and fixes into something which should be as close as
> code movement?

The ejection forces the code to build with /bin/bash, unless you apply the trivial fixes related to IFS to make it work with dash. As they are trivial the tiny semantic change during the code move is just cleaner.

> Especially Stephen's fix?

I expect Junio to apply his patch first, and then yours.  Since he
is changing a region you are moving, you need to account for it in
your patch, otherwise we have a conflict and/or a regression.

-- 
Shawn.