Re: [JGIT PATCH] The default encoding for reading commits is UTF-8 rather than system default

From: Shawn O. Pearce <spearce@spearce.org>
Date: Oct 8, 2009, 04:16 UTC
Message-ID: <20091008041609.GV9261@spearce.org>
In-Reply-To: <1254930273-1796-1-git-send-email-constantine.plotnikov@gmail.com>

Constantine Plotnikov <constantine.plotnikov@gmail.com> wrote:

> See man git-commit (the section "DISCUSSION"), for justification why 
> UTF-8 should be used. Note that this was already correctly implemented 
> in ObjectWriter.writeCommit(...) method. But Commit.decode() was not
> implemented in the same way for some reason.

Commit predates that encoding code in ObjectWriter.writeCommit and it looks like we just forgot to go back and fix it. A very old bug.

Since our move to the Eclipse Foundation we really need to follow their IP process, which for non-committers means creating a new bug in their Bugzilla system:

  https://bugs.eclipse.org/bugs/enter_bug.cgi?product=EGit

See also:

  http://wiki.eclipse.org/EGit/Contributor_Guide#Contributing_Patches

>  .../tst/org/spearce/jgit/lib/T0003_Basic.java      |    3 +++
>  .../src/org/spearce/jgit/lib/Commit.java           |   18 +++++++-----------
>  2 files changed, 10 insertions(+), 11 deletions(-)

-- 
Shawn.