Re: [PATCH] Documentation - pt-BR.

From: Jeff King <peff@peff.net>
Date: Oct 1, 2009, 12:22 UTC
Message-ID: <20091001122252.GA31919@sigill.intra.peff.net>
In-Reply-To: <20091001120711.GB5583@Pilar.aei.mpg.de>

On Thu, Oct 01, 2009 at 02:07:11PM +0200, Carlos R. Mafra wrote:

Show 13 quoted lines

> On Thu  1.Oct'09 at 13:58:46 +0200, Carlos R. Mafra wrote:
> > I read the patch. The changes are correct and improve the quality
> > of the text.
> 
> From the Portuguese point of view the change below is
> correct,
> 
> -cabeçalho Subject: e o resto no corpo.
> +cabeçalho "Assunto:", e o resto no corpo.
> 
> but I don't know if "Subject:" should be translated in
> this context. Does git-am accept "Assunto:" instead
> of "Subject:" if one is using a Portuguese locale?

No, it doesn't. It must be in English as it is an rfc2822 header. It is probably best for it to remain in English here, then, as we are specifically referring to the literal "Subject" mail header, as opposed to the more abstract concept of a subject. I think putting it in quotes makes sense, though, to indicate clearly that it is a literal technical term. I.e.:

-cabeçalho Subject: e o resto no corpo. +cabeçalho "Subject:" e o resto no corpo.

The patch in my tree has been updated in this way.

Thanks, Carlos, for the review.

-Peff