Re: git stash list shows timestamp in stead of "stash number", when setting date = local for log in config

From: Shawn O. Pearce <spearce@spearce.org>
Date: Sep 25, 2009, 22:29 UTC
Message-ID: <20090925222920.GZ14660@spearce.org>
In-Reply-To: <20090924070121.GD24486@coredump.intra.peff.net>

Jeff King <peff@peff.net> wrote:

Show 20 quoted lines

> On Tue, Sep 15, 2009 at 04:56:41PM +0200, Alf Kristian St??yle wrote:
> > When doing a "git stash list" I get this strange stash record:
> > stash@{Tue Sep 15 16:28:12 2009}: WIP on master: 2262276 ...
> > 
> > I have a global config setting on log:
> > 
> > [log]
> > date = local
> > 
> > If setting the date config to default or removing the setting, the
> > stash record looks correct:
> > stash@{0}: WIP on master: 2262276 ...
> 
> The patch below implements the former. The only downside I can think of
> is if somebody is relying on "log.date" to set the output format for
> reflogs, because they really like the date version better. In that case,
> I think we should wait for them to complain (which I doubt will happen),
> and then add a log.reflogDates config option to appease them.
> 
> Shawn, reflogs are your thing. Any comments?

I agree. I doubt anyone is relying on log.date to reformat the output of `git reflog show` or `git stash list`, so this is probably a reasonable change to make. Even if they were trying to use that, its a bug.

Care to wrap this up in a patch?

-- 
Shawn.