git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] Add "%w" to pretty formats, which rewraps the commit message

From
Johannes Gilger <heipei@hackvalue.de>
Date
Sep 23, 2009, 21:00 UTC
Message-ID
<20090923210055.GA25197@dualtron.vpn.rwth-aachen.de>
In-Reply-To
<alpine.DEB.1.00.0909232233590.4985@pacific.mpi-cbg.de>
On 23/09/09 22:34, Johannes Schindelin wrote:
> With "--pretty=format:%w(8,6,70)" you will get the commit messages
> reformatted to width 70 where the first line has indent 8 and the
> subsequent lines have indent 6.
Hey Johannes,

you sent me your patches earlier (and I really liked the idea and could use it too, especially with svn-mindset people). One thing that bothers me about the %w flag is that is includes subject and body, when we already have atoms for both of these flags. So having a subject(x,y) and body(x,y) tag (where x is indent and y is textwidth to be rewrapped) would be nicer and more in the spirit of the existing format options imho.

Having said that I also have to acknowledge a clear advantage of your patch, which is that one doesn't need to clear trailing newlines when the subject is < wrapwidth and the body is empty (and one used %s(x,y)%n%n%b(x,y) as a format-tag). With my %B, %B(n) patch which is on pu (and which you should probably consider in case it gets into next ;) I do this by calling strbuf_rtrim after adding the body.

Greetings, Jojo

-- 
Johannes Gilger <heipei@hackvalue.de>
http://heipei.net
GPG-Key: 0x42F6DE81
GPG-Fingerprint: BB49 F967 775E BB52 3A81  882C 58EE B178 42F6 DE81
Previous: Johannes SchindelinNext: Junio C Hamano
Message 12 of 18 in “git-log --format: Add %B tag with %B(x) option”
  1. git-log --format: Add %B tag with %B(x) optionJohannes Gilger, Sep 17, 2009
  2. Junio C HamanoSep 17, 2009
  3. [PATCHv2] git-log --format: Add %B tag with %B(x) optionJohannes Gilger, Sep 18, 2009
  4. Junio C HamanoSep 18, 2009
  5. [PATCHv3] git-log --format: Add %B tag with %B(x) optionJohannes Gilger, Sep 19, 2009
  6. Junio C HamanoSep 22, 2009
  7. [PATCHv4] git-log --format: Add %B tag with %B(n) optionJohannes Gilger, Sep 22, 2009
  8. 0/3 Add a pretty format to rewrapping/indenting commit messagesJohannes Schindelin, Sep 23, 2009
  9. 1/3 print_wrapped_text(): allow hard newlinesJohannes Schindelin, Sep 23, 2009
  10. 2/3 Add strbuf_add_wrapped_text() to utf8.[ch]Johannes Schindelin, Sep 23, 2009
  11. 3/3 Add "%w" to pretty formats, which rewraps the commit messageJohannes Schindelin, Sep 23, 2009
  12. Johannes GilgerSep 23, 2009
  13. Junio C HamanoSep 23, 2009
  14. Junio C HamanoOct 5, 2009
  15. Linus TorvaldsSep 24, 2009
  16. Johannes SchindelinSep 24, 2009
  17. Johannes SchindelinSep 25, 2009
  18. Junio C HamanoOct 10, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.