Re: [RFC 15/15] Tag GIT_VERSION when Git is built with MSVC
On Mittwoch, 16. September 2009, Marius Storm-Olsen wrote:
Show 25 quoted lines
> This may help us debug issues on Windows, as we now can build Git
> natively on Windows with both MinGW and MSVC.
>
> Signed-off-by: Marius Storm-Olsen <mstormo@gmail.com>
> ---
> I'm just throwing this one out there. If people think manipulating
> the version here, to ease debugging, I don't mind if this patch is
> squashed into patch 12.
> If people don't like it, just skip this path.
>
> Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index aa918eb..2c20922 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -878,6 +878,7 @@ ifneq (,$(findstring CYGWIN,$(uname_S)))
> UNRELIABLE_FSTAT = UnfortunatelyYes
> endif
> ifdef MSVC
> + GIT_VERSION := $(GIT_VERSION).MSVC
> pathsep = ;
> NO_PREAD = YesPlease
> NO_OPENSSL = YesPlease
I like it, but I would not squash it into patch 12.
-- Hannes
Johannes Sixt <j6t@kdbg.org>