Re: bash_completion outside repo

From: Jeff King <peff@peff.net>
Date: Sep 11, 2009, 14:17 UTC
Message-ID: <20090911141730.GA384@coredump.intra.peff.net>
In-Reply-To: <a3b675320909110700k7eb7286qc8cb5691aae214c7@mail.gmail.com>

On Fri, Sep 11, 2009 at 10:00:33AM -0400, james bardin wrote:

Show 7 quoted lines

> I did a make install, and dropped the completion file in
> /etc/bash_completion.d/. No other settings changed. I did a quick
> check, and it happens with the current 1.6.5 snapshot too, and on a
> fedora 10 box I found.
> 
> It seems I only get this error if I don't have a global config.
> Touching ~/.gitconfig stops the error.

Ah, I see. It looks like we use "git config --list" to view several bits of configuration. However, it is not happy if there is no config file to list.

However, I'm not sure that "config --list" isn't broken. Inside a repo, doing "git config --list" shows the repo config and my global config, and exits with no error. Outside a repo, it shows my global config, and exits with no error. But if I _don't_ have global config, it produces an error. Shouldn't it treat that as simply "no config is available"?

I also question why it is using "git config --list" at all in snippets like this:

        for i in $(git --git-dir="$d" config --list); do
                case "$i" in
                remote.*.url=*)
                        i="${i#remote.}"
                        echo "${i/.url=*/}"
                        ;;
                esac
        done

instead of just using "git config --get-regexp 'remote\..*\.url'", which would be slightly more efficient, and also doesn't have this bug. ;)

-Peff