Re: stash --dwim safety

From: Jeff King <peff@peff.net>
Date: Sep 2, 2009, 04:59 UTC
Message-ID: <20090902045937.GA12046@coredump.intra.peff.net>
In-Reply-To: <7vy6oyj892.fsf@alter.siamese.dyndns.org>

[cc'ing Dscho, as he was the main opponent of similar proposals, and I suspect his silence here means he missed this discussion. I hope this addresses his concerns, but I think it is good to get comment from all interested parties.

I'll just quote as appropriate below to comment, but for the whole patch see:

  http://article.gmane.org/gmane.comp.version-control.git/127574

On Tue, Sep 01, 2009 at 09:11:37PM -0700, Junio C Hamano wrote:

> This makes the logic of defaulting to "save" much simpler. If there is no
> non-flag arguments, it is clear that there is no command word, and we

s/is/are/ (or s/arguments/argument/)

Show 11 quoted lines

> --- a/Documentation/git-stash.txt
> +++ b/Documentation/git-stash.txt
> [...]
> -	--hard` to revert them.  This is the default action when no
> -	subcommand is given. The <message> part is optional and gives
> -	the description along with the stashed state.
> +	--hard` to revert them.  The <message> part is optional and gives
> +	the description along with the stashed state.  For quickly making
> +	a snapshot, you can omit _both_ "save" and <message>, but giving
> +	only <message> does not trigger this action to prevent misspelled
> +	subcommand from making an unwanted stash.

s/misspelled/a &/

-Peff