git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 09/15] sequencer: let "git sequencer--helper" callers set "allow_dirty"

From
Christian Couder <chriscool@tuxfamily.org>
Date
Aug 28, 2009, 04:47 UTC
Message-ID
<20090828044746.4307.53606.chriscool@tuxfamily.org>
In-Reply-To
<20090828043913.4307.34708.chriscool@tuxfamily.org>

This flag can be set when using --reset-hard or --fast-forward, and in this case changes in the work tree will be kept.

This change is usefull to let people play with the "allow_dirty" feature.

Suggested-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin-sequencer--helper.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/builtin-sequencer--helper.c b/builtin-sequencer--helper.c
index bd72f65..71a7fef 100644
--- a/builtin-sequencer--helper.c
+++ b/builtin-sequencer--helper.c
@@ -18,8 +18,10 @@ static unsigned char head_sha1[20];
 
 static const char * const git_sequencer_helper_usage[] = {
 	"git sequencer--helper --make-patch <commit>",
-	"git sequencer--helper --reset-hard <commit> <reflog-msg> <verbosity>",
-	"git sequencer--helper --fast-forward <commit> <reflog-msg> <verbosity>",
+	"git sequencer--helper --reset-hard <commit> <reflog-msg> "
+		"<verbosity> [<allow-dirty>]",
+	"git sequencer--helper --fast-forward <commit> <reflog-msg> "
+		"<verbosity> [<allow-dirty>]",
 	NULL
 };
 
@@ -247,7 +249,7 @@ int cmd_sequencer__helper(int argc, const char **argv, const char *prefix)
 		unsigned char sha1[20];
 		char *commit = ff_commit ? ff_commit : reset_commit;
 
-		if (argc != 2)
+		if (argc != 2 && argc != 3)
 			usage_with_options(git_sequencer_helper_usage,
 					   options);
 
@@ -263,6 +265,9 @@ int cmd_sequencer__helper(int argc, const char **argv, const char *prefix)
 			return 1;
 		}
 
+		if (argc == 3 && *argv[2] && strcmp(argv[2], "0"))
+			allow_dirty = 1;
+
 		if (ff_commit)
 			return do_fast_forward(sha1);
 		else
-- 
1.6.4.271.ge010d
Previous: Christian CouderNext: Christian Couder
Message 11 of 17 in “complete reroll of my "port rebase -i to C" series”
  1. 00/15 complete reroll of my "port rebase -i to C" seriesChristian Couder, Aug 28, 2009
  2. 01/15 sequencer: add "builtin-sequencer--helper.c"Christian Couder, Aug 28, 2009
  3. 02/15 sequencer: add "make_patch" function to save a patchChristian Couder, Aug 28, 2009
  4. 03/15 rebase -i: use "git sequencer--helper --make-patch"Christian Couder, Aug 28, 2009
  5. 04/15 sequencer: add "reset_almost_hard()" and related functionsChristian Couder, Aug 28, 2009
  6. Eric RaibleAug 28, 2009
  7. 05/15 sequencer: add "--reset-hard" option to "git sequencer--helper"Christian Couder, Aug 28, 2009
  8. 06/15 rebase -i: use "git sequencer--helper --reset-hard"Christian Couder, Aug 28, 2009
  9. 07/15 sequencer: add "do_fast_forward()" to perform a fast forwardChristian Couder, Aug 28, 2009
  10. 08/15 sequencer: add "--fast-forward" option to "git sequencer--helper"Christian Couder, Aug 28, 2009
  11. 09/15 sequencer: let "git sequencer--helper" callers set "allow_dirty"Christian Couder, Aug 28, 2009
  12. 10/15 rebase -i: use "git sequencer--helper --fast-forward"Christian Couder, Aug 28, 2009
  13. 11/15 revert: libify cherry-pick and revert functionnalityChristian Couder, Aug 28, 2009
  14. 12/15 pick: libify "pick_help_msg()"Christian Couder, Aug 28, 2009
  15. 13/15 sequencer: add "do_commit()" and related functions working on "next_commit"Christian Couder, Aug 28, 2009
  16. 14/15 sequencer: add "--cherry-pick" option to "git sequencer--helper"Christian Couder, Aug 28, 2009
  17. 15/15 rebase -i: use "git sequencer--helper --cherry-pick"Christian Couder, Aug 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.