Re: git http-push and MKCOL error (22/409)

From: Thomas Schlichter <thomas.schlichter@web.de>
Date: Aug 17, 2009, 17:28 UTC
Message-ID: <200908171928.38999.thomas.schlichter@web.de>
In-Reply-To: <20090817170943.180dbedd.rctay89@gmail.com>

Hi,

Am Montag 17 August 2009 11:09:43 schrieb Tay Ray Chuan:

Show 20 quoted lines

> Subject: [PATCH] http.c: don't assume that urls don't end with slash
>
> Make append_remote_object_url() (and by implication,
> get_remote_object_url) use end_url_with_slash() to ensure that the url
> ends with a slash.
>
> Previously, they assumed that the url did not end with a slash and
> as a result appended a slash, sometimes errorneously.
>
> This fixes an issue introduced in 5424bc5 ("http*: add helper methods
> for fetching objects (loose)"), where the append_remote_object_url()
> implementation in http-push.c, which assumed that urls end with a
> slash, was replaced by another one in http.c, which assumed urls did
> not end with a slash.
>
> The above issue was raised by Thomas Schlichter:
>
>   http://marc.info/?l=git&m=125043105231327
>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>

Thank you very much! This patch indeed fixes my problem.

You may add my

   Tested-by: Thomas Schlichter <thomas.schlichter@web.de>

if you'd like to. I don't know how this is handled in the git-tree...

Is there a plan in which version this patch will be released? Will there be a 1.6.4.1 or is 1.6.5 next?

Kind regards, Thomas Schlichter