git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Work around performance bug in subprocess.Popen.communicate()

From
KWKarl Wiberg <kha@virtutech.com>
Date
Aug 14, 2009, 08:12 UTC
Message-ID
<20090814081220.GA24722@lux.e.vtech>
In-Reply-To
<e87cdfda0908140026x21b8aad3x82417d4b1c8016f4@mail.gmail.com>
On 2009-08-14 09:26:06 +0200, Erik Sandberg wrote:
> Wouldn't it be better to only use the write() workaround when
> sys.version indicates that the Python bug may be present, and use
> communicate() properly otherwise?

In my opinion: no. The workaround has no negative effect (since we know that git is well-behaved). Making it conditional would only make the code more complex, without gaining us anything.

-- 
Karl Wiberg, Virtutech
Previous: Erik Sandberg
Message 7 of 7 in “Work around performance bug in subprocess.Popen.communicate()”
  1. Work around performance bug in subprocess.Popen.communicate()Karl Wiberg, Jul 31, 2009
  2. Catalin MarinasJul 31, 2009
  3. Karl WibergAug 4, 2009
  4. Catalin MarinasAug 13, 2009
  5. Karl WibergAug 14, 2009
  6. Erik SandbergAug 14, 2009
  7. Karl WibergAug 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.