Re: [PATCH] Limit git-gui to display a maximum number of files

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 11, 2009, 20:29 UTC
Message-ID: <20090811202927.GZ1033@spearce.org>
In-Reply-To: <4A81B738.7090507@zwell.net>

Dan Zwell <dzwell@zwell.net> wrote:

Show 12 quoted lines

> When there is a large number of new or modified files,
> "display_all_files" takes a long time, and git-gui appears to
> hang. This change limits the number of files that are displayed.
> This limit can be set as gui.maxfilesdisplayed, and is
> 5000 by default.
>
> A warning is shown when the list of files is truncated.
>
> Signed-off-by: Dan Zwell <dzwell@zwell.net>
> ---
> By the way, is the right way to deal with strings to be
> translated? See the end of the patch.

No.

> +			set warning "Displaying only $display_limit of "
> +			append warning "[llength $to_display] files."
> +			info_popup [mc $warning]

This should be:

info_popup [mc "Displaying only %s of %s files." $display_limit [llength $to_display]]

> +msgid "Displaying only %s of %s files."
> +msgstr ""

So that then the placeholders are available here...

-- 
Shawn.