[PATCH (resend) 3/3] Check return value of ftruncate call in http.c
- From
Tay Ray Chuan <rctay89@gmail.com>
- Date
- Aug 10, 2009, 16:05 UTC
- Message-ID
- <20090811000506.c63eb8f1.rctay89@gmail.com>
- In-Reply-To
- <20090810235955.1a659e6c.rctay89@gmail.com>
From: Jeff Lasslett <jeff.lasslett@gmail.com>
In new_http_object_request(), check ftruncate() call return value and handle possible errors.
Signed-off-by: Jeff Lasslett <jeff.lasslett@gmail.com> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com> ---
Jeff, I took out all the url-specific cleanups and expanded their scope (see earlier patches). You can safely focus on ftruncate() and do an abort there. :)
http.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/http.c b/http.c index 98f9707..14d5357 100644 --- a/http.c +++ b/http.c @@ -1187,7 +1187,11 @@ struct http_object_request *new_http_object_request(const char *base_url, if (prev_posn>0) { prev_posn = 0; lseek(freq->localfile, 0, SEEK_SET); - ftruncate(freq->localfile, 0); + if (ftruncate(freq->localfile, 0) < 0) { + error("Couldn't truncate temporary file %s for %s: %s", + freq->tmpfile, freq->filename, strerror(errno)); + goto abort; + } } } -- 1.6.3.1