Re: [PATCH v3 2/8] wt-status: move many global settings to wt_status structure
- From
Jeff King <peff@peff.net>
- Date
- Aug 10, 2009, 09:10 UTC
- Message-ID
- <20090810091010.GA7513@coredump.intra.peff.net>
- In-Reply-To
- <1249894465-11018-3-git-send-email-gitster@pobox.com>
On Mon, Aug 10, 2009 at 01:54:19AM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> --- a/wt-status.h
> +++ b/wt-status.h
> [...]
> @@ -33,8 +32,12 @@ struct wt_status {
> const char *reference;
> int verbose;
> int amend;
> - int untracked;
> int nowarn;
> + int wt_status_use_color;
> + int wt_status_relative_paths;
> + int wt_status_submodule_summary;
> + enum untracked_status_type show_untracked_files;
> +Is there a particular reason to use such enormous struct member names? IOW, inside wt_status, why not just "use_color"?
Other than that, I think this is a very positive change (and in fact, I like the way this whole series is shaping up).
-Peff