git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] svn: Add && to t9107-git-svn-migrarte.sh

From
EWEric Wong <normalperson@yhbt.net>
Date
Aug 6, 2009, 21:28 UTC
Message-ID
<20090806212841.GA13437@dcvr.yhbt.net>
In-Reply-To
<1249350039-7338-2-git-send-email-adambrewster@gmail.com>
Adam Brewster <adambrewster@gmail.com> wrote:
> It was probably intended for the test to fail unless all of the
> commands succeed.

I think you've uncovered some major breakage in this test that never got noticed until now. I'll try to take a harder look tonight or this weekend.

Fortunately, this functionality is rarely needed these days :) Thanks for the heads up!

Show 15 quoted lines
> ---
>  t/t9107-git-svn-migrate.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/t/t9107-git-svn-migrate.sh b/t/t9107-git-svn-migrate.sh
> index 3a9e077..145a367 100755
> --- a/t/t9107-git-svn-migrate.sh
> +++ b/t/t9107-git-svn-migrate.sh
> @@ -93,7 +93,7 @@ test_expect_success 'migrate --minimize on old inited layout' '
>  	grep "^branches/b:refs/remotes/b$" fetch.out &&
>  	grep "^tags/0\.1:refs/remotes/tags/0\.1$" fetch.out &&
>  	grep "^tags/0\.2:refs/remotes/tags/0\.2$" fetch.out &&
> -	grep "^tags/0\.3:refs/remotes/tags/0\.3$" fetch.out
> +	grep "^tags/0\.3:refs/remotes/tags/0\.3$" fetch.out &&
>  	grep "^:refs/${remotes_git_svn}" fetch.out
Previous: Eric WongNext: Eric Wong
Message 6 of 12 in “svn manipulate refs ourside refs/remotes”
  1. svn manipulate refs ourside refs/remotesAdam Brewster, Aug 4, 2009
  2. svn: Add && to t9107-git-svn-migrarte.shAdam Brewster, Aug 4, 2009
  3. svn: Honor --prefix option in init without --stdlayoutAdam Brewster, Aug 4, 2009
  4. svn: allow git-svn to update remotes outside of refs/remotesAdam Brewster, Aug 4, 2009
  5. Eric WongAug 10, 2009
  6. Eric WongAug 6, 2009
  7. Eric WongAug 10, 2009
  8. Adam BrewsterAug 12, 2009
  9. svn: allow branches outside of refs/remotesAdam Brewster, Aug 12, 2009
  10. Eric WongAug 12, 2009
  11. Adam BrewsterAug 13, 2009
  12. Eric WongAug 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.