Re: [PATCH] gitk: new option to hide remote refs

From: Thomas Rast <trast@student.ethz.ch>
Date: Aug 4, 2009, 09:08 UTC
Message-ID: <200908041108.19108.trast@student.ethz.ch>
In-Reply-To: <7vab2g6qkd.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 7 quoted lines

> Thomas Rast <trast@student.ethz.ch> writes:
> 
> > -	    if {![string match "*/HEAD" $name]} {
> > +	    if {![string match "*/HEAD" $name] && !$hideremotes} {
> 
> Hmm, I wonder if it would be more useful to extend this by using $skiprefs
> pattern instead, like so:

[...]

> +	if {$skiprefs != "" && [string match $skiprefs $name]} continue

Shortly after sending the patch, I had another idea: how about an option to only show refs that were given on the command line, if any? That way 'gitk --branches' or 'gitk HEAD' would hide the whole remotes mess (and of course also all other refs in the process). I think I might be able to voodoo enough Tk to implement this.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch