Re: reflogs generated by git-cvsimport

From: Jeff King <peff@peff.net>
Date: Jul 31, 2009, 20:40 UTC
Message-ID: <20090731204023.GB28226@coredump.intra.peff.net>
In-Reply-To: <87bpn0a9t9.fsf@Astalo.kon.iki.fi>

On Fri, Jul 31, 2009 at 11:15:14PM +0300, Kalle Olavi Niemitalo wrote:

Show 5 quoted lines

> That patch does not work because the $commit_read and
> $commit_write file handles fall out of scope too early.
> Those and $pid could be returned from the do {...} as
> a list, but I think it's easier to remove the "do", declare
> the variables above the block, and assign them in the block.

Oops, indeed, I clearly did not look closely. But I see you understood what I was trying to say, and I think you are right that it is probably cleaner to just "my" them right before the block.

> Also, there's $ENV{'TZ'}="UTC" at the beginning of the script
> and it affects the reflogs too.  This is the annoying part.

Since that is covering the whole script, it is obviously a harder issue and should probably be a separate patch from the GIT_COMMITTER_* information.

> The script runs numerous subprocesses and it is not clear to
> me which of those need TZ=UTC and which ones should use the
> original TZ:

Sadly, there is nothing useful in the commit history as the TZ setting goes all the way back to the script being added. I would guess it is there to convince cvs to give us a consistent time, since its log output usually comes out in the local timezone (though since cvsimport is based on cvsps, I would assume cvsps handles this sanely).

I suspect if you set it for cvs and cvsps, that would be sufficient. The rest of git should use the original.

-Peff