git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3] git apply: option to ignore whitespace differences

From
Nanako Shiraishi <nanako3@lavabit.com>
Date
Jul 29, 2009, 08:40 UTC
Message-ID
<20090729174000.6117@nanako3.lavabit.com>
In-Reply-To
<cb7bb73a0907282333g26efd1d8y7d913fba8a426aa5@mail.gmail.com>
Quoting Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Show 10 quoted lines
>> Perhaps --ignore-space-change, to be consistent with a "git diff" option,
>> would be more appropriate. Doing so has an added benefit of leaving the
>> door open to add --ignore-all-space option to the patch application side
>> later.
>
> On the other hand, --ignore-whitespace matches the option name (and
> behavior) of the 'patch' command (just like "git diff"'s matches the
> 'diff' option name and behavior). Principle of least surprise says
> that someone coming to git from raw diff/patch setups would expect
> --ignore-whitespace on the patch side.
Not everybody shares your diff/patch background.

I wouldn't be surprised if git were the first system they ever learn for majority of users of version control systems in this century, especially because now there are many books written on it.

Isn't it more important for git to be internally consistent across its commands for such an audience to satisfy the principle of least surprise?

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 8 of 15 in “[PATCHv3] git apply: option to ignore whitespace differences”
  1. Giuseppe BilottaJul 28, 2009
  2. Junio C HamanoJul 28, 2009
  3. Giuseppe BilottaJul 29, 2009
  4. Junio C HamanoJul 29, 2009
  5. Giuseppe BilottaJul 29, 2009
  6. Junio C HamanoJul 29, 2009
  7. Giuseppe BilottaJul 29, 2009
  8. Nanako ShiraishiJul 29, 2009
  9. Giuseppe BilottaJul 29, 2009
  10. Felipe ContrerasJul 31, 2009
  11. Junio C HamanoJul 31, 2009
  12. Felipe ContrerasJul 31, 2009
  13. Giuseppe BilottaJul 31, 2009
  14. Junio C HamanoJul 31, 2009
  15. Giuseppe BilottaJul 31, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.