Re: [PATCH] post-receive-email: Set content-type and encoding in generated mail
- From
Jeff King <peff@peff.net>
- Date
- Jul 29, 2009, 14:46 UTC
- Message-ID
- <20090729144610.GA5060@coredump.intra.peff.net>
- In-Reply-To
- <1248875304-13167-1-git-send-email-emmes@informatik.rwth-aachen.de>
On Wed, Jul 29, 2009 at 03:48:24PM +0200, Fabian Emmes wrote:
Show 10 quoted lines
> --- a/contrib/hooks/post-receive-email
> +++ b/contrib/hooks/post-receive-email
> @@ -197,6 +197,7 @@ generate_email_header()
> cat <<-EOF
> To: $recipients
> Subject: ${emailprefix}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe
> + Content-Type: text/plain; charset=utf-8
> X-Git-Refname: $refname
> X-Git-Reftype: $refname_type
> X-Git-Oldrev: $oldrevShouldn't this be $(git config i18n.logOutputEncoding), since you will be inserting the output of git rev-list into the mail?
And as Teemu mentioned, you need a mime-version and a transfer-encoding header, as well.
So maybe (totally untested):
---
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 2a66063..0c1c6ad 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -192,11 +192,16 @@ generate_email() generate_email_header() { + encoding=`git config i18n.logOutputEncoding` + test -z "$encoding" && encoding=utf-8 # --- Email (all stdout will be the email) # Generate header cat <<-EOF To: $recipients Subject: ${emailprefix}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe + MIME-Version: 1.0 + Content-Type: text/plain; charset=$encoding + Content-Transfer-Encoding: 8bit X-Git-Refname: $refname X-Git-Reftype: $refname_type X-Git-Oldrev: $oldrev