Re: Add option in git-am to ignore leading text?

From: Frans Pop <elendil@planet.nl>
Date: Jul 28, 2009, 19:11 UTC
Message-ID: <200907282111.14404.elendil@planet.nl>
In-Reply-To: <20090728181524.GC16168@vidovic>

On Tuesday 28 July 2009, Nicolas Sebrecht wrote:

Show 14 quoted lines

> > Here are some other examples (some of which would equally need to
> > drop or change a separator line).
> > http://lkml.org/lkml/2009/6/25/62
> Uses "From:", "Date:", and "Subject:".
>
> > http://lkml.org/lkml/2009/6/22/114
> Uses "From:" and "Subject:".
>
> > http://lkml.org/lkml/2009/6/30/109
> Uses "Subject:" only.
>
> I guess there are as results as contributors but it could be possible
> to add some rules to the format. This could ending up with an unuseable
> feature in practice, though. I don't know.

My proposal was "when it encounters _either_ a From: _or_ a Subject: pseudo header" which would work for all examples. But I fully agree with you that some rules are needed. Whether to do the same on Date: is less obvious, but I doubt that would ever be seen without at least one of the others (and the rules could specify that).

> > http://lkml.org/lkml/2009/6/30/224
> Broken link ?

Works for me, just slow.

> > And I've also seen plenty of cases where quoted lines _were_ a
> > desired part of a commit log.
>
> Yes, that's why it's an _option_.

IMHO it does not add much. My proposal would be more generic exactly because it defines the pseudo headers as a natural separator between introduction and the part of the mail git-am should act on.