Re: [PATCH] Documentation: Fix build failure of docs.

From: Thomas Rast <trast@student.ethz.ch>
Date: Jul 28, 2009, 16:02 UTC
Message-ID: <200907281802.23171.trast@student.ethz.ch>
In-Reply-To: <4A6F1B89.9080202@gmail.com>

Saikiran Madugula wrote:

> This patch fixes the build failure due to what seems to be extraneous
> characters, "+++" in the git-filter-branch.txt file.

[...]

Show 6 quoted lines

> ASCIIDOC git-filter-branch.xml
>     XMLTO git-filter-branch.1
> xmlto: input does not validate (status 1)
> /home/bobthe/git.kernel.org/git/Documentation/git-filter-branch.xml:435:
> parser error : PCDATA invalid Char value 7
> Clone it with <literal>git clone +++0+++</literal>.  The clone

NAK. Presumably you are using an asciidoc 8.x? Please check if saying

  make ASCIIDOC8=Yes man

fixes the problem. Read the comments in Documentation/Makefile for advice on what precise combination of options you should use. Also, if you do not want to actually work on docs

  make quick-install-man

is a much less painful way to get manpages (in this case, from Junio's 'man' branch that has preformatted manpages for 'master').

I put the +++ in there to stop the version I used at the time from rendering the closing backtick as part of the URL and garbling the entire paragraph in the process. To be precise, with asciidoc 8.2.7 and without the +++ I get

  Clone it with <tt>git clone <a href="file:///path/to/repo</tt">file:///path/to/repo</tt</a>>.

in the HTML output. Note the nested tags. (With asciidoc 8.4.5 the problem appears to be fixed.)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch