git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 06/11] Add support for mark references as path names

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jul 27, 2009, 18:35 UTC
Message-ID
<20090727183517.GN11191@spearce.org>
In-Reply-To
<200907272026.46150.johan@herland.net>
Johan Herland <johan@herland.net> wrote:
Show 8 quoted lines
> On Monday 27 July 2009, Shawn O. Pearce wrote:
> > I think you need to find another back door, something that the
> > language wouldn't have considered as valid previously.
> 
> Ok. One (moderately hideous) option is to introduce new commands m/d/r/c 
> that works just like M/D/R/C, except that they also expand mark 
> references (leaving M/D/R/C with the old behaviour). I don't know how 
> you'd feel about that...
Bleh.  Because I think this has more truth to it:
 
Show 12 quoted lines
> However, I'm also pondering Dscho's idea of organizing note trees into 
> hierarchies (to limit #entries in tree objects), and (although I have 
> yet to try to implement this) it feels like this transformation should 
> be done in the notes.c code, which means that it must happen on 
> the "git side" of fast-import (at least the transformation should not 
> happen on the "external side" of fast-import). This ultimately means 
> that we cannot handle notes as "regular" trees and commits (which is 
> what I'm trying to do with the help of this patch), and suggests that 
> instead of using 'commit' with 'M' for adding notes, we should probably 
> have a dedicated 'note' fast-import command that collects note objects, 
> and does the tree transformation and subsequent commit upon 
> checkpoint/exit.
Exactly.  We probably want to do this instead.

Though you might want the "note" command to be a subcommand of commit, like M/D/R/C are, because notes are wrapped up inside of a commit and you can modify multiple notes in a single commit.

-- 
Shawn.
Previous: Johan HerlandNext: Johan Herland
Message 14 of 30 in “[RFC 00/11] Foreign VCS helper program for CVS repositories”
  1. Johan HerlandJul 27, 2009
  2. 01/11 Add specification of git-vcs-* helper programsJohan Herland, Jul 27, 2009
  3. 02/11 Use a function to determine whether a remote is validJohan Herland, Jul 27, 2009
  4. 03/11 Allow programs to not depend on remotes having urlsJohan Herland, Jul 27, 2009
  5. Junio C HamanoJul 27, 2009
  6. Daniel BarkalowJul 27, 2009
  7. Alex RiesenJul 29, 2009
  8. Johan HerlandJul 30, 2009
  9. 04/11 Add a transport implementation using git-vcs-* helpersJohan Herland, Jul 27, 2009
  10. 05/11 Refactor path name parsing into new function: get_path_str()Johan Herland, Jul 27, 2009
  11. 06/11 Add support for mark references as path namesJohan Herland, Jul 27, 2009
  12. Shawn O. PearceJul 27, 2009
  13. Johan HerlandJul 27, 2009
  14. Shawn O. PearceJul 27, 2009
  15. 06/11 fast-import: Add support for importing commit notesJohan Herland, Jul 28, 2009
  16. Junio C HamanoJul 29, 2009
  17. Johan HerlandJul 29, 2009
  18. Shawn O. PearceJul 29, 2009
  19. Junio C HamanoJul 29, 2009
  20. Johan HerlandJul 30, 2009
  21. Junio C HamanoJul 30, 2009
  22. Junio C HamanoJul 29, 2009
  23. Johan HerlandJul 29, 2009
  24. 07/11 Preliminary clarifications to git-vcs documentationJohan Herland, Jul 27, 2009
  25. 08/11 Teach foreign transport code to perform the "capabilities" commandJohan Herland, Jul 27, 2009
  26. 09/11 Introduce a 'marks <filename>' feature to the foreign transport codeJohan Herland, Jul 27, 2009
  27. 11/11 Add simple test cases of git-vcs-cvs functionalityJohan Herland, Jul 27, 2009
  28. Daniel BarkalowJul 27, 2009
  29. Johan HerlandJul 27, 2009
  30. Daniel BarkalowJul 27, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.