Re: [PATCH] Preserve the protection mode for the Git config files

> This change in behaviour is justifiable only because the only thing the
> user who said "core.sharedrepository = true" cares about is that refs are
> readable by the group members (otherwise s/he would have used a more
> explicit setting like "core.sharedrepository = 0660", and the
> adjust_shared_perm() code will do the right thing, with or without your
> patch).
>
> The patch description must defend itself a bit better, perhaps by saying
> something like this at the end.
>
> 	This patch touches the codepath that affects not just .git/config
> 	but other files like the index and the loose refs, so they also
> 	inherit the original protection bits.  In a private repository,
> 	this is not an issue exactly because the repository is private,
>
> 	In a shared repository, a later call made in this function to
> 	adjust_shared_perm() widens the permission bits as configured.
> 	Because adjust_shared_perm() is designed to do so from any mode
> 	limited by user's umask, even though this patch changes the
> 	behaviour in the strict sense, it should not affect the outcome in
> 	a negative way and what is explicitly marked as allowed in the
> 	configuration will still be allowed.