Re: [PATCH] bash: gitk accepts common log-shortlog options

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Jul 22, 2009, 14:05 UTC
Message-ID: <20090722140505.GQ3581@saturnine>
In-Reply-To: <200907220036.42917.trast@student.ethz.ch>

On Wed, Jul 22, 2009 at 12:36:36AM +0200, Thomas Rast wrote:

Show 15 quoted lines

> SZEDER Gábor wrote:
> > Commit a393777e (bash completion: refactor common log, shortlog and gitk
> > options, 2009-02-16) introduced a list of command line options that go
> > well with 'git log' and 'git shortlog' but not with gitk.  However,
> > these options are all 'git rev-list' options, and, therefore, are
> > accepted by gitk, too.
> [...]
> > +	--author= --committer= --grep=
> > +	--all-match
> 
> At the time, I tried to skip options to gitk that disconnect history
> in places where it really is connected.  This applies to --author,
> --committer and --grep, which also have a GUI equivalent.  However,
> --all-match doesn't, and then the other three are also needed, so I
> guess this makes sense.

I see. I was not sure what you meant by "go well", but suspected this. However, the '--no-merges' option was already there earlier, and it also produces disconnected history. I'm not sure how often these options are used with gitk, but it just happened yesterday that I wanted to use 'gitk --author=<me> ...' to find one of my commits.

Best, Gábor