git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: cvs import and internal plumbing commands

From
Jeff King <peff@peff.net>
Date
Jul 22, 2009, 02:59 UTC
Message-ID
<20090722025934.GB31254@coredump.intra.peff.net>
In-Reply-To
<7vmy6x35ur.fsf@alter.siamese.dyndns.org>
On Tue, Jul 21, 2009 at 05:43:08PM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> Note that my suggestion on $PATH=$(git --exec-path):$PATH was a response
> to Jeff's message, which was the same message your patch was response to.
> In other words, our messages crossed, and I do not have an issue with
> fixing this either way.  If your patch fixes the issue correctly that
> would be great.

I am still confused about what the "issue" is. That is, why this is a bugfix for Anthony instead of simply a code modernization. IOW, I think there is something else broken about his install if cvsimport cannot find the dashed plumbing commands, and we may simply be papering over it.

That being said, I think the code modernization is of value itself, so let's do it.

Show 5 quoted lines
> Has anybody reviewed the submitted patch?  I do not use cvsimport these
> days anymore for anything real, so the only assurance I have on your patch
> so far are my eyeballs and whatever tests done in test scripts in the t/
> directory.  Independent "Yeah, it looks good and it works for me" would
> make me feel a bit safer.

I am lucky enough not to have needed git-cvsimport for some time, so I cannot say "it works for me." But I have read the patch; I didn't see any errors in the conversion, and assuming the conversion is done correctly, the behavior should be otherwise identical. So

Acked-by: Jeff King <peff@peff.net>
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 14 in “cvs import and internal plumbing commands”
  1. Antony StubbsJul 5, 2009
  2. Antony StubbsJul 5, 2009
  3. 1/1 Re: cvs import and internal plumbing commandsastubbs, Jul 6, 2009
  4. Jeff KingJul 16, 2009
  5. Antony StubbsJul 17, 2009
  6. Jeff KingJul 17, 2009
  7. Antony StubbsJul 17, 2009
  8. Antony StubbsJul 19, 2009
  9. Junio C HamanoJul 20, 2009
  10. Jeff KingJul 20, 2009
  11. Antony StubbsJul 21, 2009
  12. Junio C HamanoJul 22, 2009
  13. Jeff KingJul 22, 2009
  14. Junio C HamanoJul 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.