Re: [PATCH 0/2] Re: cosmetic improvements for "git show tag"

From: Jeff King <peff@peff.net>
Date: Jul 18, 2009, 01:47 UTC
Message-ID: <20090718014743.GA16381@coredump.intra.peff.net>
In-Reply-To: <20090718011006.GB12968@vidovic>

On Sat, Jul 18, 2009 at 03:10:06AM +0200, Nicolas Sebrecht wrote:

Show 18 quoted lines

> Nice. What about adding an extra newline between tags?
> 
>   $ git tag v1.6.1 v1.6.2
> 
> 	<snip>
> 
>   +  link:RelNotes-1.6.1.txt[1.6.1].
>   +
>    * link:v1.6.0.6/git.html[documentation for release 1.6.0.6]
>    
>    * release notes for
>   tag v1.6.2
>   Tagger: Junio C Hamano <gitster@pobox.com>
>   Date:   Tue Mar 3 23:37:25 2009 -0800
> 
>   <snip>
> 
> IOW, between " * release notes for" and "tag v1.6.2" here.

Hmph. I thought that should just work, because of the newline after the commit. But it seems that you only get that if the next thing is a commit. Hrm.. and it is even worse. The code to print that newline comes from printing the second commit, which says "oh, we've already printed a commit" and adds the newline.

So when you show two tags you get:

  tag foo

  message

  commit foo^{}

  message
  tag bar

  commit bar^{}

That is, the newline is actually stuck in the wrong place. So we actually need to turn that newline off, which I'm not sure is possible. I'll look into it more.

-Peff