Re: [PATCH v2] init-db: migrate to parse-options

From: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>
Date: Jul 12, 2009, 18:37 UTC
Message-ID: <20090712203716.20ac4261@gmail.com>
In-Reply-To: <7v8witn4e5.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 31 quoted lines

> Michał Kiedrowicz <michal.kiedrowicz@gmail.com> writes:
> 
> > Also add missing --bare to init-db synopsis.
> >
> > Signed-off-by: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>
> > ---
> >  Documentation/git-init-db.txt |    2 +-
> >  builtin-init-db.c             |   51
> > ++++++++++++++++++++++++----------------- 2 files changed, 31
> > insertions(+), 22 deletions(-)
> 
> The subject says patch v2 but there is no description since the
> previous round, nor ...
> 
> > diff --git a/Documentation/git-init-db.txt
> > b/Documentation/git-init-db.txt index 1fd0ff2..eba3cb4 100644
> > --- a/Documentation/git-init-db.txt
> > +++ b/Documentation/git-init-db.txt
> > @@ -8,7 +8,7 @@ git-init-db - Creates an empty git repository
> >  ...
> > diff --git a/builtin-init-db.c b/builtin-init-db.c
> > index 4a56006..d68f61b 100644
> > --- a/builtin-init-db.c
> > +++ b/builtin-init-db.c
> > @@ -6,6 +6,7 @@
> > ...
> 
> ... I see any change in the blob object name recorded on the index
> line.
> 
> What is going on?

I just added "PARSE_OPT_NONEG" flag to "shared" option in reply to Stephen's comment:

Stephen Boyd <bebarino@gmail.com> wrote:

> Or you can add PARSE_OPT_NONEG here and avoid the above comment.

Sorry I haven't described the change, I just thought it was obvious.

BTW: There is a difference:

> diff --git a/builtin-init-db.c b/builtin-init-db.c
> index 4a56006..9b1ce45 100644

and

> diff --git a/builtin-init-db.c b/builtin-init-db.c
> index 4a56006..d68f61b 100644

-- 
Michał Kiedrowicz