git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] rebase -i: use some kind of config file to save author information

From
Christian Couder <chriscool@tuxfamily.org>
Date
Jun 23, 2009, 05:30 UTC
Message-ID
<200906230730.01456.chriscool@tuxfamily.org>
In-Reply-To
<alpine.DEB.1.00.0906221117270.4168@intel-tinevez-2-302>
On Monday 22 June 2009, Johannes Schindelin wrote:
Show 27 quoted lines
> Hi,
>
> On Sun, 21 Jun 2009, Junio C Hamano wrote:
> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> > > On Sat, 20 Jun 2009, Christian Couder wrote:
> > >> This is better than saving in a shell script, because it will make
> > >> it much easier to port "rebase -i" to C. This also removes some sed
> > >> regexps and some "eval"s.
> > >
> > > It will not make it easier to port "rebase -i" to C, as this is an
> > > internal file.  The user is not supposed to touch it at all.  Only
> > > "rebase -i".  So it would be very easy to just use a different
> > > on-disk format when turning "rebase -i" into a builtin.
> >
> > "This is an internal file" is just a declaration you are making, and
> > the file is observable by anybody after "rebase -i" relinquishes the
> > control to let the user sort out the mess.
>
> It is an observation I am making.  Sure, the file is observable by the
> user.  But it is hidden deep inside .git/ and users who change things
> inside .git/ (with the exception of config) are asking for trouble.
>
> I really do not see the point of changing the file format _before_
> turning rebase -i into C.
>
> Oh, and I do not see the point of turning rebase -i into C before finally
> polishing sequencer so it can go into git.git's master.

The problem with this is that it will take a lot of time to implement the features that have been added to rebase -i since the sequencer stalled, then to polish it, and to get it reviewed and so on, and during that time other features or changes may be implemented by other people.

So I prefer to use code from the current sequencer (at http://repo.or.cz/w/git/sbeyer.git) to start porting step by step rebase -i to C.

Regards, Christian.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 8 of 13 in “rebase -i: use some kind of config file to save author information”
  1. 2/2 rebase -i: use some kind of config file to save author informationChristian Couder, Jun 20, 2009
  2. Jakub NarebskiJun 20, 2009
  3. Christian CouderJun 21, 2009
  4. Johannes SchindelinJun 21, 2009
  5. Junio C HamanoJun 21, 2009
  6. Christian CouderJun 22, 2009
  7. Johannes SchindelinJun 22, 2009
  8. Christian CouderJun 23, 2009
  9. Johannes SchindelinJun 23, 2009
  10. Christian CouderJun 24, 2009
  11. Christian CouderJun 23, 2009
  12. Junio C HamanoJun 23, 2009
  13. Christian CouderJun 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.