git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] rebase -i: use config file format to save author information

From
Christian Couder <chriscool@tuxfamily.org>
Date
Jun 21, 2009, 09:53 UTC
Message-ID
<200906211153.03969.chriscool@tuxfamily.org>
In-Reply-To
<7vhbyat6qc.fsf@alter.siamese.dyndns.org>
On Sunday 21 June 2009, Junio C Hamano wrote:
Show 18 quoted lines
> Daniel Barkalow <barkalow@iabervon.org> writes:
> >> Why is this a good change?
> >
> > It was always using a temporary file; it just used to use a temporary
> > file that was a shell script fragment and needed to be read with
> > "eval". It can't be done entirely in core because it may be determined
> > before a conflict and only used when run with --continue after the user
> > resolves the conflict.
>
> Ahh, Ok.
>
> Using a _known_ and defined format, instead of ad-hoc scriptlet, is an
> improvement.
>
> I still wonder if we can avoid using three separate "git show" and "git
> config" invocations, though.  But a half of that inefficiency will go
> away when this is migrated to C, as a single git_config() will grab all
> three, although the writing side is still very inefficient X-<.

It may be possible to write a ref to the commit we need information from. And then when "git rebase --continue" is called, we would read this ref and then get information from the referenced commit?

Best regards, Christian.

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 8 in “rebase -i: use config file format to save author information”
  1. 2/2 rebase -i: use config file format to save author informationChristian Couder, Jun 21, 2009
  2. Junio C HamanoJun 21, 2009
  3. Daniel BarkalowJun 21, 2009
  4. Junio C HamanoJun 21, 2009
  5. Jakub NarebskiJun 21, 2009
  6. Junio C HamanoJun 21, 2009
  7. Christian CouderJun 21, 2009
  8. Junio C HamanoJun 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.