Re: [PATCH v2 2/2] rebase -i: use config file format to save author information
- From
Christian Couder <chriscool@tuxfamily.org>
- Date
- Jun 21, 2009, 09:53 UTC
- Message-ID
- <200906211153.03969.chriscool@tuxfamily.org>
- In-Reply-To
- <7vhbyat6qc.fsf@alter.siamese.dyndns.org>
On Sunday 21 June 2009, Junio C Hamano wrote:
Show 18 quoted lines
> Daniel Barkalow <barkalow@iabervon.org> writes: > >> Why is this a good change? > > > > It was always using a temporary file; it just used to use a temporary > > file that was a shell script fragment and needed to be read with > > "eval". It can't be done entirely in core because it may be determined > > before a conflict and only used when run with --continue after the user > > resolves the conflict. > > Ahh, Ok. > > Using a _known_ and defined format, instead of ad-hoc scriptlet, is an > improvement. > > I still wonder if we can avoid using three separate "git show" and "git > config" invocations, though. But a half of that inefficiency will go > away when this is migrated to C, as a single git_config() will grab all > three, although the writing side is still very inefficient X-<.
It may be possible to write a ref to the commit we need information from. And then when "git rebase --continue" is called, we would read this ref and then get information from the referenced commit?
Best regards, Christian.