git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [EGIT PATCH2/2] fixed-toString-for-CommitTimeRevFilter-wrote-JUnit-tests

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Jun 16, 2009, 22:19 UTC
Message-ID
<200906170019.11627.robin.rosenberg.lists@dewire.com>
In-Reply-To
<168892.81103.qm@web27804.mail.ukl.yahoo.com>
måndag 15 juni 2009 23:36:35 skrev Mark Struberg <struberg@yahoo.de>:
Show 5 quoted lines
> 
> From 72dd9d071ce140f267b8b4effd34d122627135e6 Mon Sep 17 00:00:00 2001
> From: Mark Struberg <struberg@yahoo.de>
> Date: Mon, 15 Jun 2009 08:07:53 +0200
> Subject: [PATCH] fixed toString for CommitTimeRevFilter + wrote JUnit tests for after, before and between walks

What is the connection between the toString and the rest of the patch? Should be separate patches.

You should sign off the patches.
Start the subject with a capital letter.

Technically it seemed ok, but I shouldn't have pushed them, as I did, by mistake when pusing Shawn's latest patch. The formal errors should have been fixed firsts.

-- robin
Previous: Mark Struberg
Message 2 of 2 in “[EGIT PATCH2/2] fixed-toString-for-CommitTimeRevFilter-wrote-JUnit-tests”
  1. Mark StrubergJun 15, 2009
  2. Robin RosenbergJun 16, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.