Re: [PATCH 1/2] Makefile: refactor regex compat support
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jun 16, 2009, 18:47 UTC
- Message-ID
- <200906162047.28368.j6t@kdbg.org>
- In-Reply-To
- <20090616121126.GA11918@coredump.intra.peff.net>
On Dienstag, 16. Juni 2009, Jeff King wrote:
Show 10 quoted lines
> There was no tweakable knob to use the regex compat code; it > was embedded in the mingw build. Since other platforms may > want to use it, let's factor it out in the usual way for > build configuration knobs. > > Signed-off-by: Jeff King <peff@peff.net> > --- > This should behave the same as before on all platforms. The only one I > might have screwed up by doing it wrong is mingw, but I have no machine > to test on. Johannes, can you confirm that it is right?
It compiles and passes t/t40* (diff stuff) on Windows. But the patch conflicts with recent master, though nothing worrisome.
-- Hannes