Re: [JGIT PATCH] Fix CanonicalTreeParser.back to parse all trees correctly

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jun 12, 2009, 15:08 UTC
Message-ID: <20090612150801.GA17538@spearce.org>
In-Reply-To: <1244412116-13294-1-git-send-email-spearce@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> wrote:

> The back(int delta) method needs to walk backwards delta entries in
> the tree we are iterating.  Unfortunately, despite my attempts to do
> so, there is no reliable way to parse a canonical tree in reverse.

Ping?

Without this patch the NameConflictDirWalk can get into some serious trouble, trouble which can cause Gerrit Code Review to have its memory explode to >8 GiB, because NCDW gets stuck in an infinite loop, forever allocating reachable memory inside of a MergeStrategy.

I've made a private build of this and am running it in production
within day-job employer, but I can't make a release of Gerrit until
I have a stable identifier for this patch.

>  .../jgit/treewalk/CanonicalTreeParserTest.java     |   78 ++++++++++++++++++-
>  .../spearce/jgit/treewalk/CanonicalTreeParser.java |   74 +++++++++---------
>  2 files changed, 110 insertions(+), 42 deletions(-)

-- 
Shawn.